patrick/zephyr
1
0
Fork 0
Code Issues Pull requests Actions 8 Packages Projects Releases Wiki Activity

kernel: remove unused offload workqueue option

Browse source 
Those are used only in tests, so remove them from kernel Kconfig and set
them in the tests that use them directly.

Signed-off-by: Anas Nashif <anas.nashif@intel.com>
This commit is contained in:
Anas Nashif 2020-03-26 18:05:55 -04:00
parent 51125b2890
commit b90fafd6a0
10 changed files with 19 additions and 26 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
arch/arm/core/aarch64/Kconfig
View file

@ -49,9 +49,6 @@ config TEST_EXTRA_STACKSIZE
config SYSTEM_WORKQUEUE_STACK_SIZE
default 4096
config OFFLOAD_WORKQUEUE_STACK_SIZE
default 4096
config CMSIS_THREAD_MAX_STACK_SIZE
default 4096

3
arch/x86/core/Kconfig.intel64
View file

@ -20,9 +20,6 @@ config TEST_EXTRA_STACKSIZE
config SYSTEM_WORKQUEUE_STACK_SIZE
default 8192
config OFFLOAD_WORKQUEUE_STACK_SIZE
default 8192
config EXCEPTION_STACK_SIZE
int "Size of the exception stack(s)"
default 2048

1
boards/arm/mps2_an385/mps2_an385_defconfig
View file

@ -34,5 +34,4 @@ CONFIG_IDLE_STACK_SIZE=8192
CONFIG_PRIVILEGED_STACK_SIZE=8192
CONFIG_TEST_EXTRA_STACKSIZE=4096
CONFIG_SYSTEM_WORKQUEUE_STACK_SIZE=2048
CONFIG_OFFLOAD_WORKQUEUE_STACK_SIZE=4096
CONFIG_ISR_STACK_SIZE=4096

3
doc/guides/optimizations/footprint.rst
View file

@ -23,9 +23,6 @@ them for your application:
:option:`CONFIG_SYSTEM_WORKQUEUE_STACK_SIZE`
Set to 1024 by default
:option:`CONFIG_OFFLOAD_WORKQUEUE_STACK_SIZE`
Set to 1024 by default
:option:`CONFIG_PRIVILEGED_STACK_SIZE`
Set to 1024 by default, depends on userspace feature.

9
kernel/Kconfig
View file

@ -374,15 +374,6 @@ config SYSTEM_WORKQUEUE_PRIORITY
priority. This means that any work handler, once started, won't
be preempted by any other thread until finished.
config OFFLOAD_WORKQUEUE_STACK_SIZE
int "Workqueue stack size for thread offload requests"
default 4096 if COVERAGE
default 1024
config OFFLOAD_WORKQUEUE_PRIORITY
int "Offload requests workqueue priority"
default -1
endmenu
menu "Atomic Operations"

1
samples/net/sockets/echo_client/overlay-max-stacks.conf
View file

@ -6,7 +6,6 @@ CONFIG_SYSTEM_WORKQUEUE_STACK_SIZE=65535
CONFIG_MAIN_STACK_SIZE=65535
CONFIG_IDLE_STACK_SIZE=65535
CONFIG_ISR_STACK_SIZE=65535
CONFIG_OFFLOAD_WORKQUEUE_STACK_SIZE=65535
CONFIG_LOG_PROCESS_THREAD_STACK_SIZE=65535
CONFIG_NET_CONNECTION_MANAGER_STACK_SIZE=65535
CONFIG_SHELL_STACK_SIZE=65535

1
samples/net/sockets/echo_server/overlay-max-stacks.conf
View file

@ -6,7 +6,6 @@ CONFIG_SYSTEM_WORKQUEUE_STACK_SIZE=65535
CONFIG_MAIN_STACK_SIZE=65535
CONFIG_IDLE_STACK_SIZE=65535
CONFIG_ISR_STACK_SIZE=65535
CONFIG_OFFLOAD_WORKQUEUE_STACK_SIZE=65535
CONFIG_LOG_PROCESS_THREAD_STACK_SIZE=65535
CONFIG_NET_CONNECTION_MANAGER_STACK_SIZE=65535
CONFIG_SHELL_STACK_SIZE=65535

1
samples/net/sockets/tcp/overlay-max-stacks.conf
View file

@ -6,5 +6,4 @@ CONFIG_SYSTEM_WORKQUEUE_STACK_SIZE=65535
CONFIG_MAIN_STACK_SIZE=65535
CONFIG_IDLE_STACK_SIZE=65535
CONFIG_ISR_STACK_SIZE=65535
CONFIG_OFFLOAD_WORKQUEUE_STACK_SIZE=65535
CONFIG_LOG_PROCESS_THREAD_STACK_SIZE=65535

12
tests/kernel/critical/src/main.c
View file

@ -35,12 +35,20 @@
#define NUM_MILLISECONDS 5000
#define TEST_TIMEOUT 20000
#ifdef CONFIG_COVERAGE
#define OFFLOAD_WORKQUEUE_STACK_SIZE 4096
#else
#define OFFLOAD_WORKQUEUE_STACK_SIZE 1024
#endif
#define OFFLOAD_WORKQUEUE_PRIORITY (-1)
static u32_t critical_var;
static u32_t alt_thread_iterations;
static struct k_work_q offload_work_q;
static K_THREAD_STACK_DEFINE(offload_work_q_stack,
CONFIG_OFFLOAD_WORKQUEUE_STACK_SIZE);
OFFLOAD_WORKQUEUE_STACK_SIZE);
#define STACK_SIZE (1024 + CONFIG_TEST_EXTRA_STACKSIZE)
@ -203,7 +211,7 @@ static void init_objects(void)
k_work_q_start(&offload_work_q,
offload_work_q_stack,
K_THREAD_STACK_SIZEOF(offload_work_q_stack),
CONFIG_OFFLOAD_WORKQUEUE_PRIORITY);
OFFLOAD_WORKQUEUE_PRIORITY);
}
static void start_threads(void)

11
tests/kernel/pending/src/main.c
View file

@ -30,9 +30,16 @@
#define NON_NULL_PTR ((void *)0x12345678)
#ifdef CONFIG_COVERAGE
#define OFFLOAD_WORKQUEUE_STACK_SIZE 4096
#else
#define OFFLOAD_WORKQUEUE_STACK_SIZE 1024
#endif
#define OFFLOAD_WORKQUEUE_PRIORITY (-1)
static struct k_work_q offload_work_q;
static K_THREAD_STACK_DEFINE(offload_work_q_stack,
CONFIG_OFFLOAD_WORKQUEUE_STACK_SIZE);
OFFLOAD_WORKQUEUE_STACK_SIZE);
struct fifo_data {
intptr_t reserved;
@ -244,7 +251,7 @@ void task_high(void)
k_work_q_start(&offload_work_q,
offload_work_q_stack,
K_THREAD_STACK_SIZEOF(offload_work_q_stack),
CONFIG_OFFLOAD_WORKQUEUE_PRIORITY);
OFFLOAD_WORKQUEUE_PRIORITY);
counter = SEM_TEST_START;