patrick/zephyr
1
0
Fork 0
Code Issues Pull requests Actions 8 Packages Projects Releases Wiki Activity

drivers: gpio: pca953x: check return values from I2C API functions

Browse source 
Check the return values from the I2C API functions called in init() and
fail driver initialization if unsuccessful.

Fixes: #66827

Signed-off-by: Henrik Brix Andersen <hebad@vestas.com>
This commit is contained in:
Henrik Brix Andersen 2024-01-02 11:15:37 +01:00 committed by Carles Cufí
parent 1ee092673a
commit bc2826c1cb
1 changed files with 8 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
drivers/gpio/gpio_pca953x.c
View file

@ -444,12 +444,18 @@ static int gpio_pca953x_init(const struct device *dev)
rc = gpio_add_callback(cfg->gpio_int.port,
&drv_data->gpio_cb);
if (rc) {
goto out;
}
/* This may not present on all variants of device */
if (cfg->input_latch > -1) {
i2c_reg_write_byte_dt(&cfg->i2c, REG_INPUT_LATCH_PORT0, cfg->input_latch);
rc = i2c_reg_write_byte_dt(&cfg->i2c, REG_INPUT_LATCH_PORT0,
cfg->input_latch);
}
if (cfg->interrupt_mask > -1) {
i2c_reg_write_byte_dt(&cfg->i2c, REG_INT_MASK_PORT0, cfg->interrupt_mask);
rc = i2c_reg_write_byte_dt(&cfg->i2c, REG_INT_MASK_PORT0,
cfg->interrupt_mask);
}
}
out: