patrick/zephyr
1
0
Fork 0
Code Issues Pull requests Actions 7 Packages Projects Releases Wiki Activity

drivers: flash: bug fix inline function was not inlined

Browse source 
During flash operation, you have to disable XiP which force function
to be located in RAM. On top of that, the function `flash_put_cmd_addr`
is time critical so we need to declare as inline. For some reason,
sometimes the function was not really inline. Changed it to
ALWAYS_INLINE fixed the bug.

Signed-off-by: Mathis Raemy <mathis.raemy@gmail.com>
This commit is contained in:
Mathis Raemy 2023-01-09 08:38:28 +01:00 committed by Carles Cufí
parent 1be1b472cd
commit c4b07e8321
1 changed files with 2 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
drivers/flash/flash_rpi_pico.c
View file

@ -13,6 +13,7 @@
#include <zephyr/drivers/flash.h>
#include <zephyr/logging/log.h>
#include <zephyr/irq.h>
#include <zephyr/toolchain.h>
#include <hardware/flash.h>
#include <hardware/regs/io_qspi.h>
@ -136,7 +137,7 @@ void __no_inline_not_in_flash_func(flash_put_get_wrapper)(uint8_t cmd, const uin
flash_put_get(tx, rx, count, 1);
}
static inline void flash_put_cmd_addr(uint8_t cmd, uint32_t addr)
static ALWAYS_INLINE void flash_put_cmd_addr(uint8_t cmd, uint32_t addr)
{
flash_cs_force(OUTOVER_LOW);
addr |= cmd << 24;