patrick/zephyr
1
0
Fork 0
Code Issues Pull requests Actions 8 Packages Projects Releases Wiki Activity

driver: npcx: i2c: set a dedicated priority for the port driver

Browse source 
The NPCX I2C controller has a port-controller hierarchy and the driver
is split in two files, with separate device struct and init functions.

These are currently initialized at the same level and priority, so the
actual order depends on what the linker does.

To avoid relying on the linking order, add a dedicated priority option
for the port that is set to go after the normal I2C one by default.

Found this by building with CONFIG_CHECK_INIT_PRIORITIES.

Signed-off-by: Fabio Baltieri <fabiobaltieri@google.com>
This commit is contained in:
Fabio Baltieri 2023-05-26 10:38:38 +00:00 committed by Anas Nashif
parent 138faea796
commit c56a3615ee
2 changed files with 9 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
drivers/i2c/Kconfig.npcx
View file

@ -11,3 +11,11 @@ config I2C_NPCX
This option enables the I2C driver for NPCX family of
processors.
Say y if you wish to use I2C modules on NPCX MCU.
config I2C_NPCX_PORT_INIT_PRIORITY
int "NPCX I2C port init priority"
default 51
depends on I2C_NPCX
help
Initialization priority for the I2C port on an NPCX device, must be
set to a lower priority than the controller one (I2C_INIT_PRIORITY).

2
drivers/i2c/i2c_npcx_port.c
View file

@ -226,7 +226,7 @@ static const struct i2c_driver_api i2c_port_npcx_driver_api = {
i2c_npcx_port_init, \
NULL, NULL, \
&i2c_npcx_port_cfg_##inst, \
PRE_KERNEL_1, CONFIG_I2C_INIT_PRIORITY, \
PRE_KERNEL_1, CONFIG_I2C_NPCX_PORT_INIT_PRIORITY, \
&i2c_port_npcx_driver_api);
DT_INST_FOREACH_STATUS_OKAY(NPCX_I2C_PORT_INIT)