patrick/zephyr
1
0
Fork 0
Code Issues Pull requests Actions 7 Packages Projects Releases Wiki Activity

drivers: wifi: esp: don't queue send after socket connect

Browse source 
After a synchronous (timeout > 0) connection attempt was made, it was
being checked if there is some packet to be sent. If positive, then a
send work was queued.

This behavior makes little sense, as TCP connection is not even
considered established at this point (from net_context perspective) if
function has not returned yet. Additionally it differs from
asynchronous (timeout == 0) connection attempt. In case of UDP (and
calling esp_connect() from esp_sendto()) sock->tx_pkt is assured to be
NULL. Drop this piece of code as it doesn't seem to be justified.

Signed-off-by: Marcin Niestroj <m.niestroj@grinn-global.com>
This commit is contained in:
Marcin Niestroj 2020-12-01 15:08:03 +01:00 committed by Jukka Rissanen
parent 1814e2c8f1
commit caa35d1a3a
1 changed files with 0 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
drivers/wifi/esp/esp_offload.c
View file

@ -144,10 +144,6 @@ static int esp_connect(struct net_context *context,
ret = _sock_connect(dev, sock);
if (esp_socket_connected(sock) && sock->tx_pkt) {
k_work_submit_to_queue(&dev->workq, &sock->send_work);
}
if (ret != -ETIMEDOUT && cb) {
cb(context, ret, user_data);
}