patrick/zephyr
1
0
Fork 0
Code Issues Pull requests Actions 7 Packages Projects Releases Wiki Activity

Bluetooth: MPL: Fix use of uninitialized command.param value

Browse source 
The command.param may not always be set in send_command
depending on whether command.use_param is set.

If command.use_param is not set, the command.param is
not logged, and is set to 0.

Signed-off-by: Emil Gydesen <emil.gydesen@nordicsemi.no>
This commit is contained in:
Emil Gydesen 2022-01-24 15:49:06 +01:00 committed by Marti Bolivar
parent 3efe1e8c05
commit dc812539b8
1 changed files with 6 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
subsys/bluetooth/audio/mpl.c
View file

@ -2586,7 +2586,12 @@ void send_command(struct mpl_cmd command)
{
struct mpl_cmd_ntf ntf;
BT_DBG("opcode: %d, param: %d", command.opcode, command.param);
if (command.use_param) {
BT_DBG("opcode: %d, param: %d", command.opcode, command.param);
} else {
command.param = 0; /* ensure that is set to 0 if not used */
BT_DBG("opcode: %d", command.opcode);
}
if (pl.state < BT_MCS_MEDIA_STATE_LAST) {
ntf.requested_opcode = command.opcode;