patrick/zephyr
1
0
Fork 0
Code Issues Pull requests Actions 8 Packages Projects Releases Wiki Activity

mgmt: hawkbit: Fix NULL pointer dereferences

Browse source 
Coverity spots that null pointer is passing to flash_img_buffered_write.
This patch fixes the problem.

Signed-off-by: NavinSankar Velliangiri <navin@linumiz.com>
This commit is contained in:
NavinSankar Velliangiri 2020-09-16 09:21:33 +05:30 committed by Maureen Helm
parent a28f570855
commit dd8f135e2c
1 changed files with 11 additions and 11 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

22
subsys/mgmt/hawkbit/hawkbit.c
View file

@ -799,19 +799,19 @@ static void response_cb(struct http_response *rsp,
hb_context.dl.http_content_size = rsp->content_length;
}
if (rsp->body_found == 1) {
if (body_data == NULL) {
body_data = rsp->recv_buf;
body_len = rsp->data_len;
}
if ((rsp->body_found == 1) && (body_data == NULL)) {
body_data = rsp->recv_buf;
body_len = rsp->data_len;
}
ret = flash_img_buffered_write(&hb_context.flash_ctx, body_data,
body_len,
final_data == HTTP_DATA_FINAL);
if (ret < 0) {
LOG_ERR("flash write error");
hb_context.code_status = HAWKBIT_DOWNLOAD_ERROR;
if (body_data != NULL) {
ret = flash_img_buffered_write(&hb_context.flash_ctx,
body_data, body_len,
final_data == HTTP_DATA_FINAL);
if (ret < 0) {
LOG_ERR("flash write error");
hb_context.code_status = HAWKBIT_DOWNLOAD_ERROR;
}
}
hb_context.dl.downloaded_size =