patrick/zephyr
1
0
Fork 0
Code Issues Pull requests Actions 8 Packages Projects Releases Wiki Activity

sanitycheck: Make log_info_file() a regular function

Browse source 
Fixes this pylint warning:

    R0201: Method could be a function (no-self-use)

Could also make it a class method.

Signed-off-by: Ulf Magnusson <Ulf.Magnusson@nordicsemi.no>
This commit is contained in:
Ulf Magnusson 2019-10-29 11:54:02 +01:00 committed by Anas Nashif
parent 5c2e814212
commit e73d286b89
1 changed files with 17 additions and 16 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

33
scripts/sanitycheck
View file

@ -2009,20 +2009,6 @@ class ProjectBuilder(FilterBuilder):
with report_lock:
self.report_out()
def log_info_file(self, instance):
build_dir = instance.build_dir
h_log = "{}/handler.log".format(build_dir)
b_log = "{}/build.log".format(build_dir)
v_log = "{}/valgrind.log".format(build_dir)
if os.path.exists(v_log) and "Valgrind" in instance.reason:
log_info("{}".format(v_log))
elif os.path.exists(h_log):
log_info("{}".format(h_log))
else:
log_info("{}".format(b_log))
def report_out(self):
total_tests_width = len(str(self.suite.total_tests))
self.suite.total_done += 1
@ -2041,7 +2027,7 @@ class ProjectBuilder(FilterBuilder):
COLOR_NORMAL,
instance.reason), False)
if not VERBOSE:
self.log_info_file(instance)
log_info_file(instance)
elif instance.status == "skipped":
self.suite.total_skipped += 1
status = COLOR_YELLOW + "SKIPPED" + COLOR_NORMAL
@ -2067,7 +2053,7 @@ class ProjectBuilder(FilterBuilder):
instance.testcase.name, status, more_info))
if instance.status in ["failed", "timeout"]:
self.log_info_file(instance)
log_info_file(instance)
else:
sys.stdout.write("\rtotal complete: %s%4d/%4d%s %2d%% skipped: %s%4d%s, failed: %s%4d%s" % (
COLOR_GREEN,
@ -3395,6 +3381,21 @@ def log_info(filename):
else:
info("\n\tsee: " + COLOR_YELLOW + filename + COLOR_NORMAL)
def log_info_file(instance):
build_dir = instance.build_dir
h_log = "{}/handler.log".format(build_dir)
b_log = "{}/build.log".format(build_dir)
v_log = "{}/valgrind.log".format(build_dir)
if os.path.exists(v_log) and "Valgrind" in instance.reason:
log_info("{}".format(v_log))
elif os.path.exists(h_log):
log_info("{}".format(h_log))
else:
log_info("{}".format(b_log))
def size_report(sc):
info(sc.filename)
info("SECTION NAME VMA LMA SIZE HEX SZ TYPE")