patrick/zephyr
1
0
Fork 0
Code Issues Pull requests Actions 8 Packages Projects Releases Wiki Activity

pm: policy: Fix event integer overflow

Browse source 
In the follow expression:

cyc_evt += UINT32_MAX + 1U

first it is evaluated (UINT32_MAX + 1U), since both types
interpreted as uint32_t, this operation causes an overflow resulting
in 0U.Then we have

cyc_evt = (uint64_t)cyc_evt + 0U

Fix it casting of the operands in the first operation to uint64_t.

Signed-off-by: Flavio Ceolin <flavio.ceolin@intel.com>
This commit is contained in:
Flavio Ceolin 2024-04-23 14:20:33 -07:00 committed by Anas Nashif
parent 23d08590dd
commit ec83ab333d
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
subsys/pm/policy.c
View file

@ -113,7 +113,7 @@ static void update_next_event(uint32_t cyc)
* the comparison.
*/
if (cyc_evt < cyc) {
cyc_evt += UINT32_MAX + 1U;
cyc_evt += (uint64_t)UINT32_MAX + 1U;
}
if ((new_next_event_cyc < 0) ||
@ -124,7 +124,7 @@ static void update_next_event(uint32_t cyc)
/* undo padding for events in the [0, cyc) range */
if (new_next_event_cyc > UINT32_MAX) {
new_next_event_cyc -= UINT32_MAX + 1U;
new_next_event_cyc -= (uint64_t)UINT32_MAX + 1U;
}
next_event_cyc = new_next_event_cyc;