patrick/zephyr
1
0
Fork 0
Code Issues Pull requests Actions 8 Packages Projects Releases Wiki Activity

drivers: led_strip: tlc5971: fix brightness control bit shifting

Browse source 
The lower bits of the brightness control registers were erroneously
shifted even though FIELD_PREP already does the shifting. In practice,
the effect is negliglible but of course should be fixed.

Also add missing parenthesis around shifting operations to satisy static
analysis.

Signed-off-by: Mikkel Jakobsen <mikkel.aunsbjerg@escolifesciences.com>
This commit is contained in:
Mikkel Jakobsen 2024-02-12 12:59:08 +01:00 committed by Henrik Brix Andersen
parent 019b81a184
commit ef8e32561d
1 changed files with 4 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
drivers/led_strip/tlc5971.c
View file

@ -112,7 +112,7 @@ static inline uint8_t tlc5971_data_byte27(uint8_t control_data)
static inline uint8_t tlc5971_data_byte26(uint8_t control_data, uint8_t gbc_color_1)
{
return FIELD_PREP(TLC5971_BYTE26_CTRL_MASK, control_data) |
FIELD_PREP(TLC5971_BYTE26_GBC1_MASK, gbc_color_1 >> 2);
FIELD_PREP(TLC5971_BYTE26_GBC1_MASK, (gbc_color_1 >> 2));
}
/**
@ -124,8 +124,8 @@ static inline uint8_t tlc5971_data_byte26(uint8_t control_data, uint8_t gbc_colo
*/
static inline uint8_t tlc5971_data_byte25(uint8_t gbc_color_1, uint8_t gbc_color_2)
{
return FIELD_PREP(TLC5971_BYTE25_GBC1_MASK, gbc_color_1 << 6) |
FIELD_PREP(TLC5971_BYTE25_GBC2_MASK, gbc_color_2 >> 1);
return FIELD_PREP(TLC5971_BYTE25_GBC1_MASK, gbc_color_1) |
FIELD_PREP(TLC5971_BYTE25_GBC2_MASK, (gbc_color_2 >> 1));
}
/**
@ -137,7 +137,7 @@ static inline uint8_t tlc5971_data_byte25(uint8_t gbc_color_1, uint8_t gbc_color
*/
static inline uint8_t tlc5971_data_byte24(uint8_t gbc_color_2, uint8_t gbc_color_3)
{
return FIELD_PREP(TLC5971_BYTE24_GBC2_MASK, gbc_color_2 << 7) |
return FIELD_PREP(TLC5971_BYTE24_GBC2_MASK, gbc_color_2) |
FIELD_PREP(TLC5971_BYTE24_GBC3_MASK, gbc_color_3);
}