patrick/zephyr
1
0
Fork 0
Code Issues Pull requests Actions 8 Packages Projects Releases Wiki Activity

subsys/settings: fcb compress areas only once

Browse source 
fcb instance might use less areas than CONFIG_SETTINGS_FCB_NUM_AREAS.
During compression of completely filled up fcb it was possible to try
compress areas more than once.

What this patch fixes is not a bug - rather fix for inefficient service
of the corner case.

fixes #12657

Signed-off-by: Andrzej Puzdrowski <andrzej.puzdrowski@nordicsemi.no>
This commit is contained in:
Andrzej Puzdrowski 2019-01-23 11:16:19 +01:00 committed by Carles Cufí
parent 5b43aa52b5
commit f0616a4394
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
subsys/settings/src/settings_fcb.c
View file

@ -251,7 +251,7 @@ static int settings_fcb_save(struct settings_store *cs, const char *name,
wbs = flash_area_align(cf->cf_fcb.fap);
len = settings_line_len_calc(name, val_len);
for (i = 0; i < CONFIG_SETTINGS_FCB_NUM_AREAS; i++) {
for (i = 0; i < cf->cf_fcb.f_sector_cnt - 1; i++) {
rc = fcb_append(&cf->cf_fcb, len, &loc.loc);
if (rc != FCB_ERR_NOSPACE) {
break;