From fec3cee0bbe63898062869fcf0990d2066ffc61e Mon Sep 17 00:00:00 2001 From: Fabio Baltieri Date: Tue, 2 Apr 2024 08:49:48 +0000 Subject: [PATCH] scripts: set_maintainer: add log messages for skipped collabs Refactor the skip collaborator logic to add log messages when a collaborator is skipped because they self removed of not part of the org. Signed-off-by: Fabio Baltieri --- scripts/set_assignees.py | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/scripts/set_assignees.py b/scripts/set_assignees.py index 17199ec52e..d209193158 100755 --- a/scripts/set_assignees.py +++ b/scripts/set_assignees.py @@ -191,9 +191,15 @@ def process_pr(gh, maintainer_file, number): for collaborator in collab: try: gh_user = gh.get_user(collaborator) - if pr.user != gh_user and gh_repo.has_in_collaborators(gh_user): - if gh_user not in existing_reviewers and gh_user not in self_removal: - reviewers.append(collaborator) + if pr.user == gh_user or gh_user in existing_reviewers: + continue + if not gh_repo.has_in_collaborators(gh_user): + log(f"Skip '{collaborator}': not in collaborators") + continue + if gh_user in self_removal: + log(f"Skip '{collaborator}': self removed") + continue + reviewers.append(collaborator) except UnknownObjectException as e: log(f"Can't get user '{collaborator}', account does not exist anymore? ({e})")