a5fd0d184a
The init infrastructure, found in `init.h`, is currently used by:
- `SYS_INIT`: to call functions before `main`
- `DEVICE_*`: to initialize devices
They are all sorted according to an initialization level + a priority.
`SYS_INIT` calls are really orthogonal to devices, however, the required
function signature requires a `const struct device *dev` as a first
argument. The only reason for that is because the same init machinery is
used by devices, so we have something like:
```c
struct init_entry {
int (*init)(const struct device *dev);
/* only set by DEVICE_*, otherwise NULL */
const struct device *dev;
}
```
As a result, we end up with such weird/ugly pattern:
```c
static int my_init(const struct device *dev)
{
/* always NULL! add ARG_UNUSED to avoid compiler warning */
ARG_UNUSED(dev);
...
}
```
This is really a result of poor internals isolation. This patch proposes
a to make init entries more flexible so that they can accept sytem
initialization calls like this:
```c
static int my_init(void)
{
...
}
```
This is achieved using a union:
```c
union init_function {
/* for SYS_INIT, used when init_entry.dev == NULL */
int (*sys)(void);
/* for DEVICE*, used when init_entry.dev != NULL */
int (*dev)(const struct device *dev);
};
struct init_entry {
/* stores init function (either for SYS_INIT or DEVICE*)
union init_function init_fn;
/* stores device pointer for DEVICE*, NULL for SYS_INIT. Allows
* to know which union entry to call.
*/
const struct device *dev;
}
```
This solution **does not increase ROM usage**, and allows to offer clean
public APIs for both SYS_INIT and DEVICE*. Note that however, init
machinery keeps a coupling with devices.
**NOTE**: This is a breaking change! All `SYS_INIT` functions will need
to be converted to the new signature. See the script offered in the
following commit.
Signed-off-by: Gerard Marull-Paretas <gerard.marull@nordicsemi.no>
init: convert SYS_INIT functions to the new signature
Conversion scripted using scripts/utils/migrate_sys_init.py.
Signed-off-by: Gerard Marull-Paretas <gerard.marull@nordicsemi.no>
manifest: update projects for SYS_INIT changes
Update modules with updated SYS_INIT calls:
- hal_ti
- lvgl
- sof
- TraceRecorderSource
Signed-off-by: Gerard Marull-Paretas <gerard.marull@nordicsemi.no>
tests: devicetree: devices: adjust test
Adjust test according to the recently introduced SYS_INIT
infrastructure.
Signed-off-by: Gerard Marull-Paretas <gerard.marull@nordicsemi.no>
tests: kernel: threads: adjust SYS_INIT call
Adjust to the new signature: int (*init_fn)(void);
Signed-off-by: Gerard Marull-Paretas <gerard.marull@nordicsemi.no>
72 lines
2 KiB
C
72 lines
2 KiB
C
/*
|
|
* Copyright (c) 2015 Intel corporation
|
|
* Copyright (c) 2022 Synopsys
|
|
*
|
|
* SPDX-License-Identifier: Apache-2.0
|
|
*/
|
|
|
|
/**
|
|
* @file Software interrupts utility code - ARC implementation
|
|
*/
|
|
|
|
#include <zephyr/kernel.h>
|
|
#include <zephyr/irq_offload.h>
|
|
#include <zephyr/init.h>
|
|
|
|
/* Choose a reasonable default for interrupt line which is used for irq_offload with the option
|
|
* to override it by setting interrupt line via device tree.
|
|
*/
|
|
#if DT_NODE_EXISTS(DT_NODELABEL(test_irq_offload_line_0))
|
|
#define IRQ_OFFLOAD_LINE DT_IRQN(DT_NODELABEL(test_irq_offload_line_0))
|
|
#else
|
|
/* Last two lined are already used in the IRQ tests, so we choose 3rd from the end line */
|
|
#define IRQ_OFFLOAD_LINE (CONFIG_NUM_IRQS - 3)
|
|
#endif
|
|
|
|
#define IRQ_OFFLOAD_PRIO 0
|
|
|
|
#define CURR_CPU (IS_ENABLED(CONFIG_SMP) ? arch_curr_cpu()->id : 0)
|
|
|
|
static struct {
|
|
volatile irq_offload_routine_t fn;
|
|
const void *volatile arg;
|
|
} offload_params[CONFIG_MP_MAX_NUM_CPUS];
|
|
|
|
static void arc_irq_offload_handler(const void *unused)
|
|
{
|
|
ARG_UNUSED(unused);
|
|
|
|
offload_params[CURR_CPU].fn(offload_params[CURR_CPU].arg);
|
|
}
|
|
|
|
void arch_irq_offload(irq_offload_routine_t routine, const void *parameter)
|
|
{
|
|
offload_params[CURR_CPU].fn = routine;
|
|
offload_params[CURR_CPU].arg = parameter;
|
|
compiler_barrier();
|
|
|
|
z_arc_v2_aux_reg_write(_ARC_V2_AUX_IRQ_HINT, IRQ_OFFLOAD_LINE);
|
|
|
|
__asm__ volatile("sync");
|
|
|
|
/* If _current was aborted in the offload routine, we shouldn't be here */
|
|
__ASSERT_NO_MSG((_current->base.thread_state & _THREAD_DEAD) == 0);
|
|
}
|
|
|
|
/* need to be executed on every core in the system */
|
|
int arc_irq_offload_init(void)
|
|
{
|
|
|
|
IRQ_CONNECT(IRQ_OFFLOAD_LINE, IRQ_OFFLOAD_PRIO, arc_irq_offload_handler, NULL, 0);
|
|
|
|
/* The line is triggered and controlled with core private interrupt controller,
|
|
* so even in case common (IDU) interrupt line usage on SMP we need to enable it not
|
|
* with generic irq_enable() but via z_arc_v2_irq_unit_int_enable().
|
|
*/
|
|
z_arc_v2_irq_unit_int_enable(IRQ_OFFLOAD_LINE);
|
|
|
|
return 0;
|
|
}
|
|
|
|
SYS_INIT(arc_irq_offload_init, POST_KERNEL, 0);
|