a5fd0d184a
The init infrastructure, found in `init.h`, is currently used by:
- `SYS_INIT`: to call functions before `main`
- `DEVICE_*`: to initialize devices
They are all sorted according to an initialization level + a priority.
`SYS_INIT` calls are really orthogonal to devices, however, the required
function signature requires a `const struct device *dev` as a first
argument. The only reason for that is because the same init machinery is
used by devices, so we have something like:
```c
struct init_entry {
int (*init)(const struct device *dev);
/* only set by DEVICE_*, otherwise NULL */
const struct device *dev;
}
```
As a result, we end up with such weird/ugly pattern:
```c
static int my_init(const struct device *dev)
{
/* always NULL! add ARG_UNUSED to avoid compiler warning */
ARG_UNUSED(dev);
...
}
```
This is really a result of poor internals isolation. This patch proposes
a to make init entries more flexible so that they can accept sytem
initialization calls like this:
```c
static int my_init(void)
{
...
}
```
This is achieved using a union:
```c
union init_function {
/* for SYS_INIT, used when init_entry.dev == NULL */
int (*sys)(void);
/* for DEVICE*, used when init_entry.dev != NULL */
int (*dev)(const struct device *dev);
};
struct init_entry {
/* stores init function (either for SYS_INIT or DEVICE*)
union init_function init_fn;
/* stores device pointer for DEVICE*, NULL for SYS_INIT. Allows
* to know which union entry to call.
*/
const struct device *dev;
}
```
This solution **does not increase ROM usage**, and allows to offer clean
public APIs for both SYS_INIT and DEVICE*. Note that however, init
machinery keeps a coupling with devices.
**NOTE**: This is a breaking change! All `SYS_INIT` functions will need
to be converted to the new signature. See the script offered in the
following commit.
Signed-off-by: Gerard Marull-Paretas <gerard.marull@nordicsemi.no>
init: convert SYS_INIT functions to the new signature
Conversion scripted using scripts/utils/migrate_sys_init.py.
Signed-off-by: Gerard Marull-Paretas <gerard.marull@nordicsemi.no>
manifest: update projects for SYS_INIT changes
Update modules with updated SYS_INIT calls:
- hal_ti
- lvgl
- sof
- TraceRecorderSource
Signed-off-by: Gerard Marull-Paretas <gerard.marull@nordicsemi.no>
tests: devicetree: devices: adjust test
Adjust test according to the recently introduced SYS_INIT
infrastructure.
Signed-off-by: Gerard Marull-Paretas <gerard.marull@nordicsemi.no>
tests: kernel: threads: adjust SYS_INIT call
Adjust to the new signature: int (*init_fn)(void);
Signed-off-by: Gerard Marull-Paretas <gerard.marull@nordicsemi.no>
86 lines
1.9 KiB
C
86 lines
1.9 KiB
C
/*
|
|
* Copyright (c) 2022 Basalte bv
|
|
* Copyright (c) 2023 Gerson Fernando Budke
|
|
*
|
|
* SPDX-License-Identifier: Apache-2.0
|
|
*/
|
|
|
|
#define DT_DRV_COMPAT atmel_sam_rstc
|
|
|
|
#include <zephyr/device.h>
|
|
#include <zephyr/drivers/hwinfo.h>
|
|
#include <zephyr/drivers/clock_control/atmel_sam_pmc.h>
|
|
|
|
BUILD_ASSERT(DT_NUM_INST_STATUS_OKAY(DT_DRV_COMPAT) == 1,
|
|
"No atmel,sam-rstc compatible device found");
|
|
|
|
int z_impl_hwinfo_get_reset_cause(uint32_t *cause)
|
|
{
|
|
/* Get reason from Status Register */
|
|
uint32_t reason = ((Rstc *)DT_INST_REG_ADDR(0))->RSTC_SR & RSTC_SR_RSTTYP_Msk;
|
|
|
|
switch (reason) {
|
|
case RSTC_SR_RSTTYP_GENERAL_RST:
|
|
*cause = RESET_POR;
|
|
break;
|
|
case RSTC_SR_RSTTYP_BACKUP_RST:
|
|
*cause = RESET_LOW_POWER_WAKE;
|
|
break;
|
|
case RSTC_SR_RSTTYP_WDT_RST:
|
|
*cause = RESET_WATCHDOG;
|
|
break;
|
|
case RSTC_SR_RSTTYP_SOFT_RST:
|
|
*cause = RESET_SOFTWARE;
|
|
break;
|
|
case RSTC_SR_RSTTYP_USER_RST:
|
|
*cause = RESET_USER;
|
|
break;
|
|
default:
|
|
break;
|
|
}
|
|
|
|
return 0;
|
|
}
|
|
|
|
int z_impl_hwinfo_get_supported_reset_cause(uint32_t *supported)
|
|
{
|
|
*supported = RESET_POR
|
|
| RESET_LOW_POWER_WAKE
|
|
| RESET_WATCHDOG
|
|
| RESET_SOFTWARE
|
|
| RESET_USER;
|
|
|
|
return 0;
|
|
}
|
|
|
|
static int hwinfo_rstc_init(void)
|
|
{
|
|
Rstc *regs = (Rstc *)DT_INST_REG_ADDR(0);
|
|
const struct atmel_sam_pmc_config clock_cfg = SAM_DT_INST_CLOCK_PMC_CFG(0);
|
|
uint32_t mode;
|
|
|
|
|
|
/* Enable RSTC in PMC */
|
|
(void)clock_control_on(SAM_DT_PMC_CONTROLLER,
|
|
(clock_control_subsys_t)&clock_cfg);
|
|
|
|
/* Get current Mode Register value */
|
|
mode = regs->RSTC_MR;
|
|
|
|
/* Enable/disable user reset on NRST */
|
|
#if DT_INST_PROP(0, user_nrst)
|
|
mode &= ~RSTC_MR_KEY_Msk;
|
|
mode |= (RSTC_MR_URSTEN | RSTC_MR_KEY_PASSWD);
|
|
#else
|
|
mode &= ~(RSTC_MR_URSTEN | RSTC_MR_KEY_Msk);
|
|
mode |= RSTC_MR_KEY_PASSWD;
|
|
#endif
|
|
|
|
/* Set Mode Register value */
|
|
regs->RSTC_MR = mode;
|
|
|
|
return 0;
|
|
}
|
|
|
|
SYS_INIT(hwinfo_rstc_init, POST_KERNEL, CONFIG_KERNEL_INIT_PRIORITY_DEVICE);
|