zephyr/share/sysbuild/Kconfig.v2
Marc Herbert 811a74c019 boards/Kconfig: $BOARD_REVISION -> $(BOARD_REVISION)
Add parentheses missing around $BOARD_REVISION.

The syntax without parentheses has been deprecated for at least 5 years:
https://github.com/ulfalizer/Kconfiglib/commit/374f48873424f9

That same documentation states "Using the old syntax with an undefined
environment variable keeps the string as is." This what actually happens
on Windows where `build/zephyr/.config` looks like this:

  CONFIG_BOARD_REVISION="$BOARD_REVISION"

I found this because the behavior differs on Linux where the same,
"old" syntax produces this instead:

  CONFIG_BOARD_REVISION=""

This could be because environment variables work differently?
(BOARD_REVISION is passed from kconfig.cmake to kconfiglib.py thanks to
cmake -E env)

Let's not try to debug this and just drop the deprecated syntax. It
aligns both Windows and Linux on the same, expected, empty string
behavior.

Note these are the only two `def_string` found across all Kconfig files
right now.

Fixes commit c11b7852d1 ("Kconfig: add CONFIG_BOARD_REVISION")
Fixes commit e2ff2a88ba ("sysbuild: include HWMv2 Kconfig in sysbuild")

Signed-off-by: Marc Herbert <marc.herbert@intel.com>
2024-03-13 08:38:07 +01:00

33 lines
1 KiB
Plaintext

# Copyright (c) 2023 Nordic Semiconductor
#
# SPDX-License-Identifier: Apache-2.0
config BOARD
string
default "$(BOARD)"
help
This option holds the name of the board and is used to locate the files
related to the board in the source tree (under boards/).
The Board is the first location where we search for a linker.ld file,
if not found we look for the linker file in
soc/<arch>/<family>/<series>
config BOARD_REVISION
def_string "$(BOARD_REVISION)"
help
If the BOARD has a revision field set, this is the revision.
Otherwise, it is the empty string. For example, if BOARD is
"plank@foo", this option will be "foo". If BOARD is "plank",
this option will be the empty string.
config BOARD_DEPRECATED_RELEASE
string
help
This hidden option is set in the board configuration and indicates
the Zephyr release that the board configuration will be removed.
When set, any build for that board will generate a clearly visible
deprecation warning.
source "boards/Kconfig.$(HWM_SCHEME)"
source "soc/Kconfig.$(HWM_SCHEME)"