a5fd0d184a
The init infrastructure, found in `init.h`, is currently used by:
- `SYS_INIT`: to call functions before `main`
- `DEVICE_*`: to initialize devices
They are all sorted according to an initialization level + a priority.
`SYS_INIT` calls are really orthogonal to devices, however, the required
function signature requires a `const struct device *dev` as a first
argument. The only reason for that is because the same init machinery is
used by devices, so we have something like:
```c
struct init_entry {
int (*init)(const struct device *dev);
/* only set by DEVICE_*, otherwise NULL */
const struct device *dev;
}
```
As a result, we end up with such weird/ugly pattern:
```c
static int my_init(const struct device *dev)
{
/* always NULL! add ARG_UNUSED to avoid compiler warning */
ARG_UNUSED(dev);
...
}
```
This is really a result of poor internals isolation. This patch proposes
a to make init entries more flexible so that they can accept sytem
initialization calls like this:
```c
static int my_init(void)
{
...
}
```
This is achieved using a union:
```c
union init_function {
/* for SYS_INIT, used when init_entry.dev == NULL */
int (*sys)(void);
/* for DEVICE*, used when init_entry.dev != NULL */
int (*dev)(const struct device *dev);
};
struct init_entry {
/* stores init function (either for SYS_INIT or DEVICE*)
union init_function init_fn;
/* stores device pointer for DEVICE*, NULL for SYS_INIT. Allows
* to know which union entry to call.
*/
const struct device *dev;
}
```
This solution **does not increase ROM usage**, and allows to offer clean
public APIs for both SYS_INIT and DEVICE*. Note that however, init
machinery keeps a coupling with devices.
**NOTE**: This is a breaking change! All `SYS_INIT` functions will need
to be converted to the new signature. See the script offered in the
following commit.
Signed-off-by: Gerard Marull-Paretas <gerard.marull@nordicsemi.no>
init: convert SYS_INIT functions to the new signature
Conversion scripted using scripts/utils/migrate_sys_init.py.
Signed-off-by: Gerard Marull-Paretas <gerard.marull@nordicsemi.no>
manifest: update projects for SYS_INIT changes
Update modules with updated SYS_INIT calls:
- hal_ti
- lvgl
- sof
- TraceRecorderSource
Signed-off-by: Gerard Marull-Paretas <gerard.marull@nordicsemi.no>
tests: devicetree: devices: adjust test
Adjust test according to the recently introduced SYS_INIT
infrastructure.
Signed-off-by: Gerard Marull-Paretas <gerard.marull@nordicsemi.no>
tests: kernel: threads: adjust SYS_INIT call
Adjust to the new signature: int (*init_fn)(void);
Signed-off-by: Gerard Marull-Paretas <gerard.marull@nordicsemi.no>
79 lines
1.7 KiB
C
79 lines
1.7 KiB
C
/*
|
|
* Copyright (c) 2016 Cadence Design Systems, Inc.
|
|
* SPDX-License-Identifier: Apache-2.0
|
|
*/
|
|
|
|
#include <xtensa/simcall.h>
|
|
#include <zephyr/device.h>
|
|
#include <zephyr/init.h>
|
|
|
|
#if defined(CONFIG_PRINTK) || defined(CONFIG_STDOUT_CONSOLE)
|
|
/**
|
|
* @brief Output one character to SIMULATOR console
|
|
* @param c Character to output
|
|
* @return The character passed as input.
|
|
*/
|
|
static int console_out(int c)
|
|
{
|
|
char buf[16];
|
|
|
|
register int a2 __asm__ ("a2") = SYS_write;
|
|
register int a3 __asm__ ("a3") = 1;
|
|
register char *a4 __asm__ ("a4") = buf;
|
|
register int a5 __asm__ ("a5") = 1;
|
|
register int ret_val __asm__ ("a2");
|
|
register int ret_err __asm__ ("a3");
|
|
|
|
buf[0] = (char)c;
|
|
__asm__ volatile ("simcall"
|
|
: "=a" (ret_val), "=a" (ret_err)
|
|
: "a" (a2), "a" (a3), "a" (a4), "a" (a5)
|
|
: "memory");
|
|
return c;
|
|
}
|
|
#endif
|
|
|
|
#if defined(CONFIG_STDOUT_CONSOLE)
|
|
extern void __stdout_hook_install(int (*hook)(int));
|
|
#else
|
|
#define __stdout_hook_install(x) \
|
|
do {/* nothing */ \
|
|
} while ((0))
|
|
#endif
|
|
|
|
#if defined(CONFIG_PRINTK)
|
|
extern void __printk_hook_install(int (*fn)(int));
|
|
#else
|
|
#define __printk_hook_install(x) \
|
|
do {/* nothing */ \
|
|
} while ((0))
|
|
#endif
|
|
|
|
/**
|
|
* @brief Install printk/stdout hook for Xtensa Simulator console output
|
|
*/
|
|
static void xt_sim_console_hook_install(void)
|
|
{
|
|
__stdout_hook_install(console_out);
|
|
__printk_hook_install(console_out);
|
|
}
|
|
|
|
/**
|
|
* @brief Initialize the console/debug port
|
|
* @return 0 if successful, otherwise failed.
|
|
*/
|
|
static int xt_sim_console_init(void)
|
|
{
|
|
xt_sim_console_hook_install();
|
|
return 0;
|
|
}
|
|
|
|
/* UART console initializes after the UART device itself */
|
|
SYS_INIT(xt_sim_console_init,
|
|
#if defined(CONFIG_EARLY_CONSOLE)
|
|
PRE_KERNEL_1,
|
|
#else
|
|
POST_KERNEL,
|
|
#endif
|
|
CONFIG_CONSOLE_INIT_PRIORITY);
|