4dcfb5531c
The goal of this patch is to replace the 'void *' parameter by 'struct
device *' if they use such variable or just 'const void *' on all
relevant ISRs
This will avoid not-so-nice const qualifier tweaks when device instances
will be constant.
Note that only the ISR passed to IRQ_CONNECT are of interest here.
In order to do so, the script fix_isr.py below is necessary:
from pathlib import Path
import subprocess
import pickle
import mmap
import sys
import re
import os
cocci_template = """
@r_fix_isr_0
@
type ret_type;
identifier P;
identifier D;
@@
-ret_type <!fn!>(void *P)
+ret_type <!fn!>(const struct device *P)
{
...
(
const struct device *D = (const struct device *)P;
|
const struct device *D = P;
)
...
}
@r_fix_isr_1
@
type ret_type;
identifier P;
identifier D;
@@
-ret_type <!fn!>(void *P)
+ret_type <!fn!>(const struct device *P)
{
...
const struct device *D;
...
(
D = (const struct device *)P;
|
D = P;
)
...
}
@r_fix_isr_2
@
type ret_type;
identifier A;
@@
-ret_type <!fn!>(void *A)
+ret_type <!fn!>(const void *A)
{
...
}
@r_fix_isr_3
@
const struct device *D;
@@
-<!fn!>((void *)D);
+<!fn!>(D);
@r_fix_isr_4
@
type ret_type;
identifier D;
identifier P;
@@
-ret_type <!fn!>(const struct device *P)
+ret_type <!fn!>(const struct device *D)
{
...
(
-const struct device *D = (const struct device *)P;
|
-const struct device *D = P;
)
...
}
@r_fix_isr_5
@
type ret_type;
identifier D;
identifier P;
@@
-ret_type <!fn!>(const struct device *P)
+ret_type <!fn!>(const struct device *D)
{
...
-const struct device *D;
...
(
-D = (const struct device *)P;
|
-D = P;
)
...
}
"""
def find_isr(fn):
db = []
data = None
start = 0
try:
with open(fn, 'r+') as f:
data = str(mmap.mmap(f.fileno(), 0).read())
except Exception as e:
return db
while True:
isr = ""
irq = data.find('IRQ_CONNECT', start)
while irq > -1:
p = 1
arg = 1
p_o = data.find('(', irq)
if p_o < 0:
irq = -1
break;
pos = p_o + 1
while p > 0:
if data[pos] == ')':
p -= 1
elif data[pos] == '(':
p += 1
elif data[pos] == ',' and p == 1:
arg += 1
if arg == 3:
isr += data[pos]
pos += 1
isr = isr.strip(',\\n\\t ')
if isr not in db and len(isr) > 0:
db.append(isr)
start = pos
break
if irq < 0:
break
return db
def patch_isr(fn, isr_list):
if len(isr_list) <= 0:
return
for isr in isr_list:
tmplt = cocci_template.replace('<!fn!>', isr)
with open('/tmp/isr_fix.cocci', 'w') as f:
f.write(tmplt)
cmd = ['spatch', '--sp-file', '/tmp/isr_fix.cocci', '--in-place', fn]
subprocess.run(cmd)
def process_files(path):
if path.is_file() and path.suffix in ['.h', '.c']:
p = str(path.parent) + '/' + path.name
isr_list = find_isr(p)
patch_isr(p, isr_list)
elif path.is_dir():
for p in path.iterdir():
process_files(p)
if len(sys.argv) < 2:
print("You need to provide a dir/file path")
sys.exit(1)
process_files(Path(sys.argv[1]))
And is run: ./fix_isr.py <zephyr root directory>
Finally, some files needed manual fixes such.
Fixes #27399
Signed-off-by: Tomasz Bursztyka <tomasz.bursztyka@linux.intel.com>
84 lines
1.9 KiB
C
84 lines
1.9 KiB
C
/*
|
|
* Copyright (c) 2018 - 2019 Antmicro <www.antmicro.com>
|
|
*
|
|
* SPDX-License-Identifier: Apache-2.0
|
|
*/
|
|
|
|
#define DT_DRV_COMPAT litex_timer0
|
|
|
|
#include <kernel.h>
|
|
#include <arch/cpu.h>
|
|
#include <device.h>
|
|
#include <irq.h>
|
|
#include <spinlock.h>
|
|
#include <drivers/timer/system_timer.h>
|
|
|
|
#define TIMER_BASE DT_INST_REG_ADDR(0)
|
|
#define TIMER_LOAD_ADDR ((TIMER_BASE) + 0x00)
|
|
#define TIMER_RELOAD_ADDR ((TIMER_BASE) + 0x10)
|
|
#define TIMER_EN_ADDR ((TIMER_BASE) + 0x20)
|
|
#define TIMER_EV_PENDING_ADDR ((TIMER_BASE) + 0x3c)
|
|
#define TIMER_EV_ENABLE_ADDR ((TIMER_BASE) + 0x40)
|
|
#define TIMER_TOTAL_UPDATE ((TIMER_BASE) + 0x44)
|
|
#define TIMER_TOTAL ((TIMER_BASE) + 0x48)
|
|
|
|
#define TIMER_EV 0x1
|
|
#define TIMER_IRQ DT_INST_IRQN(0)
|
|
#define TIMER_DISABLE 0x0
|
|
#define TIMER_ENABLE 0x1
|
|
#define UPDATE_TOTAL 0x1
|
|
|
|
static void litex_timer_irq_handler(const void *device)
|
|
{
|
|
ARG_UNUSED(device);
|
|
int key = irq_lock();
|
|
|
|
sys_write8(TIMER_EV, TIMER_EV_PENDING_ADDR);
|
|
z_clock_announce(1);
|
|
|
|
irq_unlock(key);
|
|
}
|
|
|
|
uint32_t z_timer_cycle_get_32(void)
|
|
{
|
|
static struct k_spinlock lock;
|
|
uint32_t timer_total;
|
|
k_spinlock_key_t key = k_spin_lock(&lock);
|
|
|
|
litex_write8(UPDATE_TOTAL, TIMER_TOTAL_UPDATE);
|
|
timer_total = (uint32_t)litex_read64(TIMER_TOTAL);
|
|
|
|
k_spin_unlock(&lock, key);
|
|
|
|
return timer_total;
|
|
}
|
|
|
|
/* tickless kernel is not supported */
|
|
uint32_t z_clock_elapsed(void)
|
|
{
|
|
return 0;
|
|
}
|
|
|
|
int z_clock_driver_init(const struct device *device)
|
|
{
|
|
ARG_UNUSED(device);
|
|
IRQ_CONNECT(TIMER_IRQ, DT_INST_IRQ(0, priority),
|
|
litex_timer_irq_handler, NULL, 0);
|
|
irq_enable(TIMER_IRQ);
|
|
|
|
sys_write8(TIMER_DISABLE, TIMER_EN_ADDR);
|
|
|
|
for (int i = 0; i < 4; i++) {
|
|
sys_write8(k_ticks_to_cyc_floor32(1) >> (24 - i * 8),
|
|
TIMER_RELOAD_ADDR + i * 0x4);
|
|
sys_write8(k_ticks_to_cyc_floor32(1) >> (24 - i * 8),
|
|
TIMER_LOAD_ADDR + i * 0x4);
|
|
}
|
|
|
|
sys_write8(TIMER_ENABLE, TIMER_EN_ADDR);
|
|
sys_write8(sys_read8(TIMER_EV_PENDING_ADDR), TIMER_EV_PENDING_ADDR);
|
|
sys_write8(TIMER_EV, TIMER_EV_ENABLE_ADDR);
|
|
|
|
return 0;
|
|
}
|