patrick/zephyr
1
0
Fork 0
Code Issues Pull requests Actions 8 Packages Projects Releases Wiki Activity

mgmt: fs_mgmt: clear lock before return

Browse source 
Not clearing that lock lead to the fs_mgmt commands being useless, after
the mgmt callback returned `MGMT_CB_ERROR_RC` once, since the lock is now
occupied and never cleared.

Fixes #66581

Signed-off-by: Ruben Völl <ruben.voell@grandcentrix.net>
This commit is contained in:
Ruben Völl 2023-12-15 19:25:49 +01:00 committed by Fabio Baltieri
parent 9804c60a4e
commit 2b83e91a43
1 changed files with 2 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
subsys/mgmt/mcumgr/grp/fs_mgmt/src/fs_mgmt.c
View file

@ -255,6 +255,7 @@ static int fs_mgmt_file_download(struct smp_streamer *ctxt)
if (status != MGMT_CB_OK) { if (status != MGMT_CB_OK) {
if (status == MGMT_CB_ERROR_RC) { if (status == MGMT_CB_ERROR_RC) {
k_sem_give(&fs_mgmt_ctxt.lock_sem);
return err_rc; return err_rc;
} }
@ -404,6 +405,7 @@ static int fs_mgmt_file_upload(struct smp_streamer *ctxt)
if (status != MGMT_CB_OK) { if (status != MGMT_CB_OK) {
if (status == MGMT_CB_ERROR_RC) { if (status == MGMT_CB_ERROR_RC) {
k_sem_give(&fs_mgmt_ctxt.lock_sem);
return err_rc; return err_rc;
} }